Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next-plugin: prepare for app dir support #1022

Closed
wants to merge 4 commits into from

Conversation

graup
Copy link
Collaborator

@graup graup commented Mar 3, 2023

This by itself doesn't solve next 13 app dir compatibility, but it seems this will be one of the necessary steps.

See
#1013 (comment)
#929 (comment)

Leaving this here until we resolved the other open questions and ran some more tests.

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2023

🦋 Changeset detected

Latest commit: a94f01b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vanilla-extract/next-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graup graup changed the title Fix part of #929 next: prepare for app dir support Mar 3, 2023
@graup graup changed the title next: prepare for app dir support next-plugin: prepare for app dir support Mar 6, 2023
Copy link
Contributor

@michaeltaranto michaeltaranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we confirm this doesn't break previous versions due to config validation then we should be good to go on this.

@SuttonJack
Copy link

SuttonJack commented Apr 11, 2023

I have a test repo running this patch on nextv13.3.0 + app directory. (vercel preview here)

Anything preventing the merge of this right now?

@mattcompiles
Copy link
Contributor

Closing in favour of #1060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants